Bottomhalf example cleanup and doc update #338
Merged
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorLYJ
force-pushed
the
modfiy-bh-part
branch
from
261623c to
f7b7075
Compare
jserv
reviewed
Aug 26, 2025
Comment on lines
+1988
to
+2111
| A common way to avoid blocking the interrupt for a significant duration | ||
| is to defer the time-consuming part to a workqueue. |
There was a problem hiding this comment.
Improve the writing for rationale.
There was a problem hiding this comment.
Are you suggesting that the rationale behind the change needs more explanation, or
Is the issue with the tone and professionalism of the writing itself?
There was a problem hiding this comment.
Are you suggesting that the rationale behind the change needs more explanation?
I meant that you can consolidate BH descriptions, such as the removal of tasklet.
eleanorLYJ
force-pushed
the
modfiy-bh-part
branch
from
f7b7075 to
a41a967
Compare
jserv
reviewed
Sep 3, 2025
lkmpg.tex
Outdated
| such as memory management issues and unpredictable latencies. | ||
| Instead, they recommend more robust mechanisms like workqueues or softirqs. | ||
| To address tasklet shortcomings, Linux contributors introduced the BH workqueue, | ||
| activated with the WQ_BH flag. This workqueue retains critical features, |
There was a problem hiding this comment.
Add \cpp to WQ_BH.
Split the sentence starting with "This workqueue" into a newline.
EricccTaiwan
reviewed
Sep 3, 2025
lkmpg.tex
Outdated
| Instead, they recommend more robust mechanisms like workqueues or softirqs. | ||
| To address tasklet shortcomings, Linux contributors introduced the BH workqueue, | ||
| activated with the WQ_BH flag. This workqueue retains critical features, | ||
| such as execution in atomic (softirq) context on the same CPU and the inability to sleep. |
There was a problem hiding this comment.
Nit: Add \textbf{softirq} for consistency
Commit 3682d9e ("Move bottom-half to workqueue for safe sleep") migrated the example code away from tasklets to workqueues. However, the compatibility macro DECLARE_TASKLET_OLD was left behind even though tasklets are no longer used. Remove the unused macro for consistency and clarity.
Since commit 3682d9e ("Move bottom-half to workqueue for safe sleep") switched the implementation to workqueues, update the description accordingly to avoid confusion and reflect the modern approach to bottom-half handling. Explain the issues with tasklets and introduce the BH workqueue as the new, reliable alternative.
eleanorLYJ
force-pushed
the
modfiy-bh-part
branch
from
a41a967 to
6807fb9
Compare
|
Thank @eleanorLYJ for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits:
Keep the code and docs consistent, avoiding confusion.